Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some deprecations in advance of Drupal 11 #1026

Merged
merged 9 commits into from
Jul 31, 2024
Merged

Some deprecations in advance of Drupal 11 #1026

merged 9 commits into from
Jul 31, 2024

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Jun 4, 2024

GitHub Issue: Islandora/documentation#2318

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What does this Pull Request do?

Removes deprecated code per the following:

How should this be tested?

  • Run tests locally (deprecation notices seem to be suppressed in CI). You shouldn't be able to track down these errors to issues in Islandora code (note that not all contrib modules have used the new API for defining field type categories so those may pop up but it seems it's not our fault.)

Documentation Status

  • Does this change existing behaviour that's currently documented? no!
  • Does this change require new pages or sections of documentation? no!
  • Who does this need to be documented for? nobody!
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

Draft because there are a lot more problems when running tests locally.

@seth-shaw-asu
Copy link
Member

The new Field Type API is 10.2+. The note appears to say we can add 10.1 support by adding a hook.

@rosiel rosiel marked this pull request as ready for review June 5, 2024 16:56
@rosiel
Copy link
Member Author

rosiel commented Jun 6, 2024

Hmm. With 2 weeks till the release of 10.3, and the end of security support for 10.1.x, I think we should move toward declaring the module now requires 10.2 or greater. (If it makes people feel better, we could wait two weeks and then do this).

@rosiel
Copy link
Member Author

rosiel commented Jun 12, 2024

add composer conflicts.

@jordandukart jordandukart self-assigned this Jun 19, 2024
jordandukart
jordandukart reviewed Jun 26, 2024
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@jordandukart
Copy link
Member

Rest here I think looks fine.

@jordandukart jordandukart removed their assignment Jun 26, 2024
@adam-vessey adam-vessey mentioned this pull request Jul 31, 2024
Closed
@joecorall joecorall merged commit 9fd63e5 into Islandora:2.x Jul 31, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordandukart jordandukart jordandukart left review comments

@adam-vessey adam-vessey adam-vessey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rosiel @seth-shaw-asu @jordandukart @adam-vessey @joecorall